Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Improve permit join. #1214

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Oct 7, 2024

  • Match Controller API more closely to Adapter: (time, device?)
  • Clamp time to [0-254] (never forever)
  • Remove "forever permit join" (security concerns + sometimes unstable behavior)
  • Remove reason (unused)
  • getPermitJoinTimeout returns [0-254] range, with 0 being "not permitting joining".
  • Remove getPermitJoin => use getPermitJoinTimeout instead (boolean easily determined on other end of mqtt transaction -see below-)
  • For Z2M: Less unnecessary mqtt data required/published in various places (/bridge/info, /request/permit_join)

TODO:

  • fix: Improve permit join zigbee2mqtt#24257
  • Remove unnecessary mqtt publish of /bridge/info every time the permit join timer ticks (the other end of mqtt transaction should be responsible for the ticks, and z2m should only publish begin -possibly end for extra sync purposes-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Removal of "forever" Permit Join
1 participant