Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in predict.train.kknn #27

Open
rkangr opened this issue Oct 24, 2024 · 0 comments
Open

Mistake in predict.train.kknn #27

rkangr opened this issue Oct 24, 2024 · 0 comments

Comments

@rkangr
Copy link

rkangr commented Oct 24, 2024

In some settings it is useful to control scaling variables from outside of kknn. Unfortunately, when train.kknn is used with scale=FALSE, the corresponding predict method does not pass this parameter to kknn used inside predict.train.kknn, so predictions are still computed with default scaling. It seems, that a possible solution would be to add scale component to the value of train.kknn and use that component in predict.train.kknn

Could this mistake be corrected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant