-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cv.kknn fold sizes are different #14
Comments
mkuehn10
added a commit
to mkuehn10/kknn
that referenced
this issue
Sep 2, 2018
I also added a random shuffling of the rows of the data that is passed in prior to assigning folds.
|
Hi @mkuehn10 , |
Hello @KlausVigo. Have you had any chance to look this over? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The line
val<-sample(kcv, size=l, replace=TRUE)
has the potential to make different sized folds for the cross-validation.A simple fix could be to do
val <- cut(seq(1, nrow(data)), breaks = kcv, labels = FALSE)
instead to make the folds as similar in size as possible.The text was updated successfully, but these errors were encountered: