From 63f327270325d827181ae1eaa0a4601c61fba67e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sean=20-Kjell-=20Hedstr=C3=B6m?= Date: Sun, 12 Nov 2023 14:42:52 -0700 Subject: [PATCH] clarify c++ version support (#502) --- Build.cmake | 2 +- docs/building.md | 2 +- docs/g3log.md | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Build.cmake b/Build.cmake index 8fc1cf06..726f230d 100644 --- a/Build.cmake +++ b/Build.cmake @@ -86,7 +86,7 @@ IF(APPLE) SET_TARGET_PROPERTIES(${G3LOG_LIBRARY} PROPERTIES MACOSX_RPATH TRUE) ENDIF() -# require here some proxy for c++14 standard to avoid problems TARGET_PROPERTY CXX_STANDARD +# require here some proxy for c++14/c++17? standard to avoid problems TARGET_PROPERTY CXX_STANDARD TARGET_COMPILE_FEATURES(${G3LOG_LIBRARY} PUBLIC cxx_variable_templates) TARGET_INCLUDE_DIRECTORIES(${G3LOG_LIBRARY} diff --git a/docs/building.md b/docs/building.md index 732676a3..cae52f5b 100644 --- a/docs/building.md +++ b/docs/building.md @@ -15,7 +15,7 @@ cd build ``` ## Prerequisites -Assume you have got your shiny C++14 compiler installed, you also need these tools to build g3log from source: +You also need these tools to build g3log from source: - CMake (*Required*) g3log uses CMake as a one-stop solution for configuring, building, installing, packaging and testing on Windows, Linux and OSX. diff --git a/docs/g3log.md b/docs/g3log.md index 30cd2ceb..560bb8b6 100644 --- a/docs/g3log.md +++ b/docs/g3log.md @@ -67,7 +67,11 @@ The logger will catch certain fatal events *(Linux/OSX: signals, Windows: fatal 8. The code is given for free as public domain. This gives the option to change, use, and do whatever with it, no strings attached. -9. *[g3log](https://github.com/KjellKod/g3log)* : is made to facilitate easy adding of custom log receivers. Its tested on at least the following platforms with **Linux**(Clang/gcc), **Windows** (mingw, visual studio) and **OSX**. My recommendation is to go with g3log if you have full C++14 support (C++11 support up to version: https://github.com/KjellKod/g3log/releases/tag/1.3.1). +9. *[g3log](https://github.com/KjellKod/g3log)* : is made to facilitate easy adding of custom log receivers. Its tested on at least the following platforms with **Linux**(Clang/gcc), **Windows** (mingw, visual studio) and **OSX**. My recommendation is to go with g3log if you have full C++17 support + +C++11 support up to version: https://github.com/KjellKod/g3log/releases/tag/1.3.1). + +C++14 support up to version: https://github.com/KjellKod/g3log/releases/tag/1.3.4 ## G3log with sinks