Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive Qt panel to VR scene #43

Open
8 of 10 tasks
cpinter opened this issue Oct 3, 2018 · 10 comments
Open
8 of 10 tasks

Add interactive Qt panel to VR scene #43

cpinter opened this issue Oct 3, 2018 · 10 comments
Assignees
@sankhesh @cpinter
Labels
enhancement

Comments

@cpinter
Copy link
Collaborator

cpinter commented Oct 3, 2018 •
edited
Loading

A very flexible way for showing menus in VR would be to implement off-line rendering of any Qt widget in a texture that is shown on a VTK plane actor, which can respond to virtual mouse events generated by the laser pointer (currently called probe mode in VTK) in VR.

Tasks that need to be done, start with first and only move to next one once it is done.

  • Generate 2D texture with Qt of arbitrary QWidget. Done when you have a QImage or QPixmap containing a QWidget with some other widgets in it (for example a QFrame with a QVBoxLayout having a QCheckBox and a QSlider on it) so that the widget is never shown on the Windows desktop (i.e. everything happens in the background).
  • Show texture generated in the previous step on a VTK plane actor (for example vtkImageActor). Done when the Qt GUI is visible in the scene shown in VR (positioning can be arbitrary at this point).
  • Refactor VR interactor style according the new events design (Csaba)
  • Re-add laser pointer (called probe mode in vtkOpenVRMenu*), TBD
  • Send laser pointer events to Qt, re-render the widget if necessary, TBD
  • Create default "pipboy" style panel with basic settings. Show up attached to left forearm if left controller is turned outside 180(ish) degrees. Make panel look like it's obviously interactive (back side not visible, slight frame on the edges, etc.)

Useful UI panels (extend as needs arise):

  • "Main menu" widget that takes the user to the "apps" (below)
  • Subject hierarchy (show/hide)
  • Segment Editor (simplified)
  • Interaction settings: group objects (moving them under the same interaction transform), toggle selectable, etc.

Related issues

Related pull requests
@pieper
Copy link

pieper commented Oct 3, 2018

💯 this will be a great feature!

@cpinter cpinter mentioned this issue Oct 22, 2018
Open
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue May 21, 2019
@mohammadrashid0917 @cpinter
ENH: Add VR optimized Qt Style Sheet
93baf29 
This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43
@jcfr
Copy link
Contributor

jcfr commented May 23, 2019

To follow up on this, @martinken recently added classes to VTK for adding Qt widget into the VR scene:

@cpinter
Copy link
Collaborator Author

cpinter commented May 23, 2019

@jcfr Perfect! @mohammadrashid0917 just started working on this. We'll re-adjust the plan to use these classes. Mohammad, please hang on. In the meantime you can look at these classes.

@lassoan
Copy link
Collaborator

lassoan commented May 23, 2019

@jcfr We were lucky this time that minimal/no work was duplicated, but we need to coordinate a bit more closely to make sure we avoid parallel efforts. How could we do that? Where can we find planned VTK virtual reality developments? Do you have a category in the VTK bugtracker, labs page, …?

@jcfr
Copy link
Contributor

jcfr commented May 23, 2019

How could we do that?

The plan described at the top of this issue is outstanding. I should probably have done a better job communicating about it with folks working on OpenVR at Kitware.

Moving forward, I think sharing the plan like the one at the top of this issue on VTK discourse would help.

Internally, the folks working on OpenVR features know that I am coordinating effort on the Slicer side and I think it worked pretty well as I was able to follow up here.

That said, I agreed that the feedback loop could be shorter.

May be having a list of contact associated with key VTK area would help ?

Where can we find planned VTK virtual reality developments?

Considering that this type of feature are driven by customer needs and often planned and executed in a short time frame, i think it is challenging for us to communicate about this features with a high level of granularity and far ahead.

@jcfr
Copy link
Contributor

jcfr commented May 23, 2019 •
edited
Loading

To follow up, here is a Slicer PR backporting the specific VTK changes to Slicer/VTK fork. See Slicer/Slicer#1141

I have checked that it compiles on Linux, after someone check that Slicer/VTK compiles on Windows and macOS, it will be integrated.

cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue May 31, 2019
@mohammadrashid0917 @cpinter
ENH: Make VR home widget controls functional
450e81e 
These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 14, 2019
@mohammadrashid0917 @cpinter
ENH: Create framework for registering VR modules
24fb665 
Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jul 11, 2019
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
612f7d3 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
881fa92 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Add VR optimized Qt Style Sheet
27bc060 
This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Make VR home widget controls functional
b0fc67b 
These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Create framework for registering VR modules
1d97551 
Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
c280ca7 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 28, 2019
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
3925264 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
691692f 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
2f49db8 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
c9443fa 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
9c9ed1c 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
b7f9351 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 30, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
f77cdbd 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 4, 2021
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
bb65154 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 4, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
e7a8b80 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Oct 4, 2021
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
034d838 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
jcfr pushed a commit to jcfr/SlicerVirtualReality that referenced this issue Apr 9, 2023
@SalehChoueib @cpinter
@dgmato @mohammadrashid0917 @jcfr
ENH: Initial VR home widget implementation
27c945d 
This commit is intended to implement features described in KitwareMedical#43
by integrating changes originally associated with the following
branches:

* dgmato/gui-widgets-interactions
  - initially developed between 2021-12-15 and 2022-05-23 by @dgmato
    with contributions from @cpinter.
  - based on the "gui-widgets-module" branch

* dgmato/gui-widgets-module
  - initially developed between 2018-10-18 and 2021-10-0523 by @cpinter
    with contributions from @dgmato, @lassoan, @SalehChoueib and @mohammadrashid0917
  - with first commit titled "ENH: Initial VR home widget implementation"
    based of "dgmato/virtual-widget" branch.

* dgmato/virtual-widget
  - initial commit contributed by @SalehChoueib on 2018-10-18 (ENH: Add virtual widget
    from arbitrary Qt Widget !WIP!)
  - follow-up development by @cpinter and @mohammadrashid0917
    between 2019-05-13 and 2019-06-13

------------
Commits originally associated with branch "dgmato/gui-widgets-interactions":

* ENH: Remove unused UI widget in GUI Widgets module

* ENH: Do not load avatar models when setting up VR pointer

* ENH: Add new button to set up interaction
  Set up will include getting the VR controller transform node and applying that transform to the pointer model.

* ENH: Add GUIWidgets module to Virtual Reality category for easy access

* ENH: Load avatar models and transform pointer by right controller transform

* ENH: Reorganize code and remove unused code

* COMP: Fix build error due to Slicer API changes

* ENH: Add new module target library
  vtkSlicerMarkupsModuleMRMLDisplayableManager

* ENH: Send mouse release event to complete simulated mouse click after press event

* ENH: Modify coordinate system for GUI widget
  Origin is located on the top left corner in Qt widgets.

* ENH: Add button "Start interaction" to simulate interaction with VR pointer

* ENH: Add module to simulate VR pointer display and movement

------------
Commits originally associated with branch "dgmato/gui-widgets-module":

* ENH: Add buttons in GUIWidgets to show VR widgets; Fix include dirs variable in CMake

* ENH: Add GUIWidgets module that provides in-VR Qt widget

  This is still a prototype, a few crucial features are needed:
  - Handle mouse interactions on the widget: forward events to Qt
  - Support moving the widget to arbitrary position
    - Implement outline tube and handle to grab with the controller
    - Option to keep widget floating in certain position relative to head motion (~HUD)
  - Implement laser pointer and use the intersection with these widgets as mouse interaction

  See more history: https://github.com/cpinter/VtkQWidgetTest

* ENH: Creating and registering VR segment editor widget
  Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

* BUG: Fix issues in VR home widget and the data widget

* ENH: Creating and registering VR data module widget
  Creates and registers the VR data module widget (which can be switched to from the VR home widget)

* ENH: Convert the interactor style to use the new vtkMRMLViewInteractorStyle
  Fix build error with Slicer-4.10

* STYLE: Add function documentation

* ENH: Initial VR home widget implementation

  Squashed commits (originally associated with branch "dgmato/virtual-widget")

  * ENH: Create framework for registering VR modules
    Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

  * ENH: Make VR home widget controls functional
    These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa

  * ENH: Add VR optimized Qt Style Sheet
    This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.

  * ENH: Add VR home widget WIP
    Its UI is more or less complete but events are not handled and style sheet is needed

  * ENH: Add virtual widget from arbitrary Qt Widget !WIP!

Co-authored-by: Andras Lasso <[email protected]>
Co-authored-by: Csaba Pinter <[email protected]>
Co-authored-by: David Garcia Mato <[email protected]>
Co-authored-by: Mohammad Rashid <[email protected]>
Co-authored-by: Sal Choueib <[email protected]>
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 12, 2023
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
add6f56 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 12, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
4f307a4 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 12, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
951a45a 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 12, 2023
@cpinter
COMP: Fix build after merging GUI widget interaction branch
5fb1b82 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 13, 2023
@cpinter
BUG: Fix pointer simulator module
6da15ca 
Some widgets were missing from the UI

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 13, 2023
@cpinter
ENH: Make widget plane face the camera by default
6d60b00 
Formerly we saw the widget "from behind" when it appeared.

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 14, 2023
@cpinter
BUG: Fixed crash when starting VR after showing a GUI widget
9378b25 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
BUG: Fixed widget texture update in VR view
a439d5f 
A workaround was implemented, a better solution will be needed in the long run.

Re KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
99fe76d 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
949a2ac 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
e610014 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
COMP: Fix build after merging GUI widget interaction branch
7cbf223 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
BUG: Fix pointer simulator module
a07d849 
Some widgets were missing from the UI

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
ENH: Make widget plane face the camera by default
85742ff 
Formerly we saw the widget "from behind" when it appeared.

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
BUG: Fixed crash when starting VR after showing a GUI widget
4d8d58e 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
BUG: Fixed widget texture update in VR view
5e0111f 
A workaround was implemented, a better solution will be needed in the long run.

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
ENH: Re-enable pick event to use it with the GUI widget
5fe1e95 
At the start of the Pick event the interactor style invokes vtkCommand::PickEvent.
With this Python script it is possible to do the clicking with the right trigger.

  def onClick(caller, event):
    gw.onStartInteractionButtonClicked()

  vris = slicer.modules.virtualreality.viewWidget().interactor().GetInteractorStyle()
  vris.MapInputToAction(vtk.vtkEventDataDevice.RightController, vtk.vtkEventDataDeviceInput.Trigger, vtk.VTKIS_PICK)
  vris.AddObserver(vtk.vtkCommand.PickEvent, onClick)

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Jun 15, 2023
@cpinter
BUG: Fix interaction bug with laser pointer
7f09ce4 
Without this fix, although the first button press worked on any child widget of the set GUI widget, after this first click, no other button reacted to the interaction. Now all the buttons in the GUI widget work as expected.

Re KitwareMedical#43
@cpinter
Copy link
Collaborator Author

cpinter commented Jun 15, 2023 •
edited
Loading

Using the branch https://github.com/cpinter/SlicerVirtualReality/tree/gui-widget-20230612 the interactions can be set up to work like shown in this video:

2023-06-15.VRWidgetDemo.mp4

Note that I had to apply a few workwrounds in the code and use a bunch of scripting to achieve this. Next steps can be:

  • Laser pointer is set up from the PointerSimulator Python module. Need to move the setup and the controller transform setting code to GUIWidgets
  • Bind the menu button to show/hide the widget
    • When shown, bind the pick event to the trigger, otherwise use the default grab&move
  • Make the GUIWidget markup node respect the parent transform
  • Add handle to the widget so that it can be moved around (need to make it work with the above task)
  • Separate press and release events to be able to drag a slider
  • Refactor code so that GUIWidgets and VirtualReality modules are not so entangled
    • See handling of Pick event, which currently simply invokes an event, but it should perform the click instead
  • Remove workarounds applied to make the interactions work (see vtkSlicerQWidgetRepresentation::OnTextureModified)

cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@SalehChoueib @cpinter
ENH: Initial VR home widget implementation
edf7fb9 
Squashed commits:

ENH: Create framework for registering VR modules

Adds registerModule function to qMRMLVRView which can be called to create a new button for that module on the Modules bar in the VR home widget

KitwareMedical#43

ENH: Make VR home widget controls functional

These changes make it so that changes in the module widget (viewable in Slicer) are reflected in the home widget (viewable in VR) and vice versa
KitwareMedical#43

ENH: Add VR optimized Qt Style Sheet

This style sheet makes the text in the VR menu widget bigger, and gives the buttons and slider handles different colors for unpressed, hover, and pressed statuses.
KitwareMedical#43

ENH: Add VR home widget WIP

Its UI is more or less complete but events are not handled and style sheet is needed

ENH: Add virtual widget from arbitrary Qt Widget !WIP!
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR data module widget
a8fca31 
Creates and registers the VR data module widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter pushed a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@mohammadrashid0917 @cpinter
ENH: Creating and registering VR segment editor widget
cd0e5fe 
Creates and registers the VR segment editor widget (which can be switched to from the VR home widget)

KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
COMP: Fix build after merging GUI widget interaction branch
ab3bfb9 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
BUG: Fix pointer simulator module
aa70c84 
Some widgets were missing from the UI

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
ENH: Make widget plane face the camera by default
76d7b69 
Formerly we saw the widget "from behind" when it appeared.

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
BUG: Fixed crash when starting VR after showing a GUI widget
d8cc5c2 
Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
BUG: Fixed widget texture update in VR view
856efa5 
A workaround was implemented, a better solution will be needed in the long run.

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
ENH: Re-enable pick event to use it with the GUI widget
84b633d 
At the start of the Pick event the interactor style invokes vtkCommand::PickEvent.
With this Python script it is possible to do the clicking with the right trigger.

  def onClick(caller, event):
    gw.onStartInteractionButtonClicked()

  vris = slicer.modules.virtualreality.viewWidget().interactor().GetInteractorStyle()
  vris.MapInputToAction(vtk.vtkEventDataDevice.RightController, vtk.vtkEventDataDeviceInput.Trigger, vtk.VTKIS_PICK)
  vris.AddObserver(vtk.vtkCommand.PickEvent, onClick)

Re KitwareMedical#43
cpinter added a commit to cpinter/SlicerVirtualReality that referenced this issue Aug 22, 2023
@cpinter
BUG: Fix interaction bug with laser pointer
3e16903 
Without this fix, although the first button press worked on any child widget of the set GUI widget, after this first click, no other button reacted to the interaction. Now all the buttons in the GUI widget work as expected.

Re KitwareMedical#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sankhesh sankhesh

@cpinter cpinter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@pieper @jcfr @lassoan @sankhesh @cpinter @adamrankin @SalehChoueib @mohammadrashid0917