Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for images uploaded via ATTACHED_FILES #2376

Open
codeling opened this issue Aug 2, 2024 · 2 comments
Open

Better support for images uploaded via ATTACHED_FILES #2376

codeling opened this issue Aug 2, 2024 · 2 comments

Comments

@codeling
Copy link

codeling commented Aug 2, 2024

When uploading files via the ATTACHED_FILES property of a test, CDash (as of version 3.4.3, not tested with 3.5 RC's yet) currently always displays a .tgz-wrapped version of those files. It would be immensely helpful if images uploaded via this mechanism (.png, .jpg) were treated similarly as images uploaded via the CTestMeasurement mechanism - that they are shown directly on the test page.

This would avoid quite some extra effort on test writing side for having to upload images via the CTestMeasurement mechanism in order to have images show up directly in CDash (see also this cmake discourse post).

@codeling codeling changed the title Better support images in ATTACHED_FILES Better support for images in ATTACHED_FILES Aug 2, 2024
@codeling codeling changed the title Better support for images in ATTACHED_FILES Better support for images uploaded via ATTACHED_FILES Aug 2, 2024
@zackgalbreath
Copy link
Contributor

Thanks for taking the time to write this up (and the even more detailed discourse post linked above).

I'm okay with tracking this feature request here, but I think the actual code changes will probably end up in CTest, right?

@codeling
Copy link
Author

codeling commented Aug 6, 2024

I'm okay with tracking this feature request here, but I think the actual code changes will probably end up in CTest, right?

I am only a user of both CTest and CDash, so I don't really have any insights on where things would need to be changed in order to achieve this.
I'll gladly report this on CTest side if you say it is more appropriate there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants