Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image mapping not available after IIIF manifest import #10

Open
Ennego opened this issue Sep 20, 2023 · 5 comments
Open

Image mapping not available after IIIF manifest import #10

Ennego opened this issue Sep 20, 2023 · 5 comments

Comments

@Ennego
Copy link

Ennego commented Sep 20, 2023

Hello! I'm having an issue mapping images from a IIIF manifest. After importing the manifest, going to the "map images" screen, and selecting "uploaded images," I do not see the manifest images as an option in the backlog box. Any suggestions?

Here is the IIIF manifest: https://figgy.princeton.edu/concern/scanned_resources/ac79d75c-1d0f-4605-b006-8b14785adb84/manifest

@leoba
Copy link
Collaborator

leoba commented Sep 20, 2023

Confirming that this is an issue. I created a test project and uploaded both this manifest and one from Penn's Colenda system. Both of them show up as being imported, but only the Colenda manifest is available for mapping in the drop-down (see screnshots)
Screen Shot 2023-09-20 at 9 35 37 AM
Screen Shot 2023-09-20 at 9 36 19 AM

@Ennego
Copy link
Author

Ennego commented Sep 20, 2023

The IIIF Presentation API validator does give some warnings for this Princeton manifest (below), although it is valid presentation 2.1. Could any of these warnings be the cause of the issue for VCEditor?

  • URL does not have correct access-control-allow-origin header: got "", expected *
  • The remote server did not use the requested gzip transfer compression, which will slow access. (Content-Encoding: )
  • WARNING: Setting non-standard field 'rendering' on resource of type 'sc:Manifest'
  • WARNING: Setting non-standard field 'rendering' on resource of type 'sc:Canvas'
  • WARNING: Setting non-standard field 'rendering' on resource of type 'sc:Sequence'
  • WARNING: Resource type 'dctypes:Image' should have 'format' set
  • WARNING: Resource type 'dctypes:Image' should have 'height' set
  • WARNING: Resource type 'dctypes:Image' should have 'width' set

@tpendragon
Copy link

@Ennego @leoba Hi! Developer from Princeton here. It looks like your code doesn't support multiple manifest labels. I'm seeing this error in the console:

EditManifest.js:74 Uncaught TypeError: r.state.name.trim is not a function

When I put a break point there I get this:

r.state.name
['Missal, use of Seville.']

It's valid for a manifest to have multiple labels - it looks like your code should probably wrap label to an array and pick the first one?

Presentation API:

A Manifest must have the label property with at least one entry.

Thanks!

@leoba
Copy link
Collaborator

leoba commented Oct 4, 2023

Thank you @tpendragon !

@demery is this something we can take care of now or should I add it to my wish list for the grant proposal?

@Ennego
Copy link
Author

Ennego commented Oct 16, 2023

@demery just checking back on @leoba's question. I would like to use the Princeton manifest to map the images to a collation model the fast &easy way if possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants