Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer / Generator summary doesn't display on non-English builds #795

Open
jaredpar opened this issue Aug 6, 2024 · 1 comment
Open

Comments

@jaredpar
Copy link
Contributor

jaredpar commented Aug 6, 2024

The analyzer and generator summary nodes are created by looking for the following strings in a Message node in the binary log:

  • Total analyzer execution time:
  • Total generator execution time:

That marks the beginning of the summary output and the viewer will parse out the nodes below that. The problem is that those strings in the compiler are localizable strings. That means on non-English builds they will have different values. The strings in the viewer are hard coded. That means they won't match and the viewer won't produce summary nodes for analyzers or generators.

I'm not sure what the best way is to fix this. The compiler needs to emit localized messages here as it's part of the standard compiler output that is localized. There is no reasonable way for the viewer to match this across locale's.

Open to suggestions on how to best approach this problem.

@KirillOsenkov
Copy link
Owner

if you have a sample binlog, can you send it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants