Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing final flag from transition-dapp CLI and all logic partaining to non-final RollApp state submissions #679

Open
kmlbgn opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels

Comments

@kmlbgn
Copy link
Collaborator

kmlbgn commented Jun 25, 2024

Description

Currently, the transition-dapp CLI does not provide a flag for indicating whether a submission is final. This absence means that the entire logic surrounding non-final submissions, including the ability to make multiple submissions during a session and the discarding of approvals from Verifiers with each new submission, is not implemented.

Expected Behavior

The transition-dapp CLI should include a final flag to indicate whether a submission by the leader is final for a session. This would enable the proper handling of non-final submissions, such as allowing multiple submissions during a session. For each submission, all gathered approvals from Verifiers are discarded. However, Verifiers performance counter should be kept to ensure correct distribution of rewards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants