Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor convert-dapp-pool and add CLI for Cross-App LP Token Swapping #678

Open
2 tasks
kmlbgn opened this issue Jun 20, 2024 · 0 comments
Open
2 tasks
Assignees
Labels
Priority: High refactor Codebase cleaning & improvement x/layer2

Comments

@kmlbgn
Copy link
Collaborator

kmlbgn commented Jun 20, 2024

Description

Current logic for convert-dapp-pool is wrong and need to be refactored according to #675. There is no CLI to swap LP tokens either.

Expected Behaviour

  • Refactor convert-dapp-pool. It should abstract 2 swaps from 2 RollApps pool.

  • A CLI tool to facilitate the process of swapping LP tokens between different apps should also be added. The CLI should abstract and automate the following steps:

  1. Redeem LP tokens from App1 (==obtaining Y dp and X kex from App1).
  2. Sell Y dp from App1 for X kex using App1 pool.
  3. Buy Z dp from App2 with X kex
  4. Pool (deposit liquidity) X kex and Z dp from App2.
  5. Obtain LP tokens from App2 from this deposit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High refactor Codebase cleaning & improvement x/layer2
Projects
None yet
Development

No branches or pull requests

2 participants