Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version parameter is missing #677

Open
5 tasks
kmlbgn opened this issue Jun 10, 2024 · 0 comments
Open
5 tasks

version parameter is missing #677

kmlbgn opened this issue Jun 10, 2024 · 0 comments
Assignees
Labels

Comments

@kmlbgn
Copy link
Collaborator

kmlbgn commented Jun 10, 2024

Description

version param is missing from dApp or BinaryInfo object.

func (dapp Dapp) Version() string {
if len(dapp.Bin) > 0 {
return dapp.Bin[0].Hash
}
return ""
}

message BinaryInfo {
string name = 1; // filename identifying source such as container, executable, config, finality gadget, etc.
string hash = 2; // hash of the file
string source = 3; // link to the source (from where the file should be fetched)
string reference = 4; // link to github repository or audit
string type = 5; // optional file type, e.g. binary, archive, text, image, etc.
}

Expected Behaviour

This parameters should be added and the logic surrounding it should be checked:

  • Whenever changes are made to binary files of the dApp, the application version must be changed, otherwise the proposal raising will fail.
  • The version must be included and match the application version when the leader submits a new dApp state transition.
  • The transition, approval and rejection transactions related to the dApp session state must include the dApp version.
  • The state transition transaction will fail if the dApp version is not correct.
  • Verifiers must include the version in their approval transactions and it must match the application version. If the version does not match, or if the session leader tries to send the approval transaction for their own state transition, the transaction must fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants