Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dapp_pool_fee Network Property #674

Open
kmlbgn opened this issue Jun 3, 2024 · 0 comments
Open

Missing dapp_pool_fee Network Property #674

kmlbgn opened this issue Jun 3, 2024 · 0 comments
Assignees
Labels

Comments

@kmlbgn
Copy link
Collaborator

kmlbgn commented Jun 3, 2024

Description

Current logic uses dapp.PoolFee to fetch fee for dp/denom swap and redemption, but this value is never set, even at pool creation.
Additionally, a TODO related to the fee application has not been addressed:

func (k Keeper) OnCollectFee(ctx sdk.Context, fee sdk.Coins) error {
// TODO: The fixed fee will be applied after the swap from where
// - `50%` of the corresponding tokens must be **burned** (deminted)
// - `25%` given as a reward to liquidity providers
// - `25%` will be split between **ACTIVE** dApp executors, and verifiers (fisherman).
// Additionally, the premint and postmint tokens can be used to incentivize operators before
// dApp starts to generate revenue.
err := k.bk.BurnCoins(ctx, types.ModuleName, fee)
if err != nil {
return err
}
return nil
}

Expected Behaviour

dApps pool fee cannot be set by owners and should be set network-wide through a network property called dapp_pool_fee when the dApp proposal is approved.
The TODO should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants