You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current logic uses dapp.PoolFee to fetch fee for dp/denom swap and redemption, but this value is never set, even at pool creation.
Additionally, a TODO related to the fee application has not been addressed:
// TODO: The fixed fee will be applied after the swap from where
// - `50%` of the corresponding tokens must be **burned** (deminted)
// - `25%` given as a reward to liquidity providers
// - `25%` will be split between **ACTIVE** dApp executors, and verifiers (fisherman).
// Additionally, the premint and postmint tokens can be used to incentivize operators before
// dApp starts to generate revenue.
err:=k.bk.BurnCoins(ctx, types.ModuleName, fee)
iferr!=nil {
returnerr
}
returnnil
}
Expected Behaviour
dApps pool fee cannot be set by owners and should be set network-wide through a network property called dapp_pool_fee when the dApp proposal is approved.
The TODO should be addressed.
The text was updated successfully, but these errors were encountered:
Description
Current logic uses
dapp.PoolFee
to fetch fee fordp/denom
swap and redemption, but this value is never set, even at pool creation.Additionally, a TODO related to the fee application has not been addressed:
sekai/x/layer2/keeper/lp_swap_redeem_convert.go
Lines 18 to 30 in 1b8573d
Expected Behaviour
dApps pool fee cannot be set by owners and should be set network-wide through a network property called
dapp_pool_fee
when the dApp proposal is approved.The TODO should be addressed.
The text was updated successfully, but these errors were encountered: