Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling when portions of falcor request fail #3

Open
LukeTillman opened this issue Aug 30, 2016 · 1 comment
Open

Better error handling when portions of falcor request fail #3

LukeTillman opened this issue Aug 30, 2016 · 1 comment

Comments

@LukeTillman
Copy link
Member

Add better error handling and indications in the UI when parts of a Falcor JSON graph return error objects. This should include, for example, not leaving the "Loading" spinner showing indefinitely in video lists.
jeffreyscarpenter pushed a commit that referenced this issue Apr 20, 2017
Squashed 'lib/killrvideo-docker-common/' changes from 0c67c94..be86c0f
e60a06e 
be86c0f Merge pull request #3 from KillrVideo/dse-5.1.0-update
bf4126c Update to new Docker image for DSE 5.1.0
19e1fac Switch to killrvideo-dse image
a102c4b Create lo0 alias and use when doing Docker for Mac setup
aa4f607 Don't need to specify IP to bind
c60aebe Hardcode IPs on Docker for Mac
4c5d1d6 Specify IP when publishing ports
ffcd0ee Make get environment script executable
bc68e1e Make create environment script executable
d887201 Add create environment shell script
58411ae Add a little documentation to shell script
0500cf9 Update shell script for docker toolbox setups
f16318a Add COMPOSE_FILE to output

git-subtree-dir: lib/killrvideo-docker-common
git-subtree-split: be86c0f837500393e1e7f6c223f0d285ec6e71ba
@jeffreyscarpenter
Copy link
Member

A possible instance of this issue was discovered in implementing the KillrVideo Python services. In the SuggestedVideosService, when a list of video IDs is provided to the "get number of plays" operation, if some of the videos do not yet have any statistics in the database, that video was omitted from the results. The killrvideo-web application does not respond well when no stats are returned for one of the videos requested - it appears to "hang" with spinny ball and an error mentioning "views" not existing is found in the console. @mando222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeTillman @jeffreyscarpenter