Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Travis does not check symbol if only DCM file is changed #306

Open
antoniovazquezblanco opened this issue Jun 27, 2019 · 2 comments
Open

Comments

@antoniovazquezblanco
Copy link
Collaborator

See KiCad/kicad-symbols#1551

It seems that the Travis scripts do not detect change when only the DCM file is changed. Example at KiCad/kicad-symbols#1490, only the new symbols of the PR have been checked by Travis.

@poeschlr
Copy link
Collaborator

Well do we want the symbol to be checked if only the description is updated? I am not so sure here. (The user did not touch the symbol. Why should they be responsible to fix old issues?)

@antoniovazquezblanco
Copy link
Collaborator Author

Anyways, the tool should at least notify the librarians that it has been changed so that we can review the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants