Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Fix vertex input when unused #9312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencer-lunarg
Copy link
Contributor

closes #9305

We had the VUs a bit mixed up

  • VUID-vkCmdDraw-None-04007 - Makes sure you call vkCmdBindVertexBuffers on the binding
  • VUID-vkCmdDraw-None-04008 - If you bound VK_NULL_HANDLE, need nullDescriptor
  • VUID-vkCmdDraw-None-02721 - The values are OOB inside (also done on GPU-AV)

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner January 24, 2025 21:20
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 355534.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18858 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18858 failed.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-we-created-way-too-many-ways-to-do-vertex-buffers-no-fun branch from 9565065 to b33a82e Compare January 24, 2025 22:58
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 355611.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18859 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18859 aborted.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 355687.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18861 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18861 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore unbound VkVertexInputBindingDescription
2 participants