PlaneDetectorEXT::getPlaneDetectionStateEXT still broken

[jherico]

The enhanced function contains this code

  XrPlaneDetectionStateEXT state_tmp;
  PlaneDetectionStateEXT state;
  Result result = static_cast<Result>(
      d.xrGetPlaneDetectionStateEXT(this->get(), state_tmp));

But the dispatcher call here expects a XrPlaneDetectionStateEXT* as it's second argument, not a XrPlaneDetectionStateEXT.

[jherico]

This may also apply to Session::thermalGetTemperatureTrendEXT. This is the only other function I can find which has an output enum type.

I don't get why extension authors seem to be avoiding the convention of "Everything is wrapped in an extensible structure", especially with the above thermalGetTemperatureTrendEXT where it has 3 output pointers being passed instead of a single output structure pointer. That means the C++ code ends up looking more like C code because you can't do an enhanced foo = session.thermalGetTemperatureTrendEXT() with the signature like it is.

Although I see your name is on XR_EXT_performance_settings so sorry if that's your design I'm complaining about.

[rpavlik]

The thermal stuff is ancient, as old as basically anything else in the spec. Most new stuff is nearly going too far in the direction of everything in a struct. :)