Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flow with TypeScript #371

Open
lencioni opened this issue Apr 6, 2019 · 3 comments
Open

Replace flow with TypeScript #371

lencioni opened this issue Apr 6, 2019 · 3 comments

Comments

@lencioni
Copy link
Collaborator

lencioni commented Apr 6, 2019

What do folks think? Should we switch everything over to TypeScript?

@kevinbarabash
Copy link
Contributor

If we do, we can generate flow type definitions using https://github.com/joarwilk/flowgen.

@kevinbarabash
Copy link
Contributor

After think about this some more, I think that staying with flow and generating TypeScript lib defs is probably the way to go. The API is pretty small so generating lib defs shouldn't be too bad. Flow's type safety is a lot better that TypeScript's. Beyond lib defs are there other reasons why we'd want to switch?

@lencioni
Copy link
Collaborator Author

lencioni commented Nov 3, 2019

Beyond lib defs are there other reasons why we'd want to switch?

More people are familiar with TypeScript, so switching will make it easier for those folks to contribute to this project. And, as TypeScript's popularity continues to outpace Flow's, this will be increasingly the case.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants