Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint enum #15

Open
ajcord opened this issue Jan 5, 2017 · 0 comments
Open

Endpoint enum #15

ajcord opened this issue Jan 5, 2017 · 0 comments

Comments

@ajcord
Copy link
Contributor

ajcord commented Jan 5, 2017

While working on #14, I discovered that the Endpoint enum in TICL.h has at least one incorrect value (COMP89 should be 0x08). Also, I find it confusing that it only has values for calc->CBL but not the other way around.

I propose using constants more similar to libticalcs' defines along with another enum of just the calculator models, CBL, and PC. Then there can be a mapping function that takes the sender and receiver and outputs the correct machine ID. This would avoid programs assuming incorrect machine IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants