Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[88] Add keplog.py #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ecalifornica
Copy link

@ecalifornica ecalifornica commented Feb 18, 2018

This commit is a first pass to resolve #88, converting pyke to more Pythonic
logging.

I have diffs ready to migrate the other files to use keplog.py, but the diffs are large and mechanical so I wanted feedback on the approach before moving forward.

This is a first pass at issue KeplerGO#88, converting pyke to more Pythonic
logging.
@codecov
Copy link

codecov bot commented Feb 18, 2018

Codecov Report

Merging #189 into master will increase coverage by 0.03%.
The diff coverage is 43.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   33.64%   33.67%   +0.03%     
==========================================
  Files          65       66       +1     
  Lines       10468    10505      +37     
==========================================
+ Hits         3522     3538      +16     
- Misses       6946     6967      +21
Impacted Files Coverage Δ
pyke/keplog.py 43.24% <43.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3fcc0...3112719. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agree on a "printing and logging" convention for PyKE
1 participant