Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] -No Hand Cursor on Dark and Light Mode Button #394

Open
mnik7044 opened this issue Apr 28, 2023 · 19 comments
Open

[FEATURE REQUEST] -No Hand Cursor on Dark and Light Mode Button #394

mnik7044 opened this issue Apr 28, 2023 · 19 comments
Labels
enhancement New feature or request

Comments

@mnik7044
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When hovering over the dark and light mode button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor. This issue is present on all pages of the website.

Describe the solution you'd like
To fix this issue, you could add a CSS rule to change the cursor to a hand when hovering over the button. For example:

Why do you think we should add this feature? How will it be useful for the project?
User experience: Adding a hand cursor to clickable elements is a common convention in web design, and it helps users understand that a particular element is interactive. Without a hand cursor on the dark and light mode button, users may not realize that it is clickable, which could result in a poor user experience.

Consistency: If the website uses a hand cursor for other clickable elements, such as links or buttons, it would be consistent with web design conventions to also use a hand cursor for the dark and light mode button. This would create a more unified and cohesive user experience.

@mnik7044 mnik7044 added the enhancement New feature or request label Apr 28, 2023
@mnik7044
Copy link
Contributor Author

Hey @KendallDoesCoding I think I can fix this issue please assign it to me.

@KendallDoesCoding
Copy link
Owner

Is your feature request related to a problem? Please describe. When hovering over the dark and light mode button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor. This issue is present on all pages of the website.

Describe the solution you'd like To fix this issue, you could add a CSS rule to change the cursor to a hand when hovering over the button. For example:

Why do you think we should add this feature? How will it be useful for the project? User experience: Adding a hand cursor to clickable elements is a common convention in web design, and it helps users understand that a particular element is interactive. Without a hand cursor on the dark and light mode button, users may not realize that it is clickable, which could result in a poor user experience.

Consistency: If the website uses a hand cursor for other clickable elements, such as links or buttons, it would be consistent with web design conventions to also use a hand cursor for the dark and light mode button. This would create a more unified and cohesive user experience.

@mnik7044 - thanks for bringing this to my notice. Please work on this.

@KendallDoesCoding KendallDoesCoding removed their assignment Apr 29, 2023
@mnik7044
Copy link
Contributor Author

mnik7044 commented May 4, 2023

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

@KendallDoesCoding
Copy link
Owner

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

it should be in index.js

@mnik7044
Copy link
Contributor Author

mnik7044 commented May 4, 2023

Ya looked for it, the structure of code is quite different from what I have worked with before.

@mnik7044
Copy link
Contributor Author

mnik7044 commented May 4, 2023

But let me try.

@KendallDoesCoding
Copy link
Owner

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

it should be in index.js

Yeah. We have to format code slightly better.

@KendallDoesCoding
Copy link
Owner

@mnik7044 - still can't seem to figure it out?

@mnik7044
Copy link
Contributor Author

mnik7044 commented Jun 6, 2023

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

@mnik7044
Copy link
Contributor Author

mnik7044 commented Jun 6, 2023

Do you have a discord or slack for this website @KendallDoesCoding ?

@KendallDoesCoding
Copy link
Owner

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

Ok. All the best with your end sem!

@KendallDoesCoding
Copy link
Owner

Do you have a discord or slack for this website @KendallDoesCoding ?

I have discord, you can reach me on Kendall#9903, what's your discord username?

@mnik7044
Copy link
Contributor Author

mnik7044 commented Jun 6, 2023

Mine is GodNik#1720

@mnik7044
Copy link
Contributor Author

mnik7044 commented Jun 6, 2023

Screenshot_2023-06-07-01-25-20-51_572064f74bd5f9fa804b05334aa4f912.jpg

Got this

@KendallDoesCoding
Copy link
Owner

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

Hey. Are you working on this @mnik7044 ?

@KendallDoesCoding
Copy link
Owner

Mine is GodNik#1720

sent a friend req

@KendallDoesCoding
Copy link
Owner

Hi @mnik7044 - Are you working on this?

@Michael-Obele
Copy link
Contributor

Hey, @KendallDoesCoding, I can help with this issue if it's okay.

@kotlalokeshwari098
Copy link

Hey , I came across this issue and would love to work on it.
Could you confirm if it's still open? If available, could you please assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants