Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "open in editor" button to screens in the following format #874

Closed
KaaayKaay opened this issue Jun 16, 2024 · 3 comments
Closed

Add "open in editor" button to screens in the following format #874

KaaayKaay opened this issue Jun 16, 2024 · 3 comments
Labels
feature request The mod needs this

Comments

@KaaayKaay
Copy link

KaaayKaay commented Jun 16, 2024

Idea

Add the "Open in editor" button to the following screen format shown below + allow placeholders

Screenshot 2024-06-16 152853

Use case

A text input field linked to the variable "colour" where the user can type in the HEX code of the colour theme they want for the modpack UI

That same variable would be used in the "rectangle shape" element's colour property as show below

image

Extra info

Would work very well with the ability to change hue as shown in #873

@Keksuccino
Copy link
Owner

It's not as easy as "adding a button". Every element internally needs to support upating their values to update placeholders. I would need to constantly update colors to make placeholders work and I decided not to do that when coding v3.

@Keksuccino Keksuccino closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@Keksuccino
Copy link
Owner

Every placeholder update eats performance. I optimized that process in v3, but it's still a heavy task.

@KaaayKaay
Copy link
Author

Every placeholder update eats performance. I optimized that process in v3, but it's still a heavy task.

Fair, I have noticed some performance issues with placeholders, tickers and variables so I can understand.

Maybe consider for advanced mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request The mod needs this
Projects
None yet
Development

No branches or pull requests

2 participants