Include report of unscannable files in MissingLibraryException #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
To reduce ambiguity, we would want to report unscannable files whenever we're querying for
getSupportedABIs()
. This is done by:File
s information in addition to the supported ABIs.getSupportedABIs()
's catch clause to capture said information.MissingLibraryException
to report it.Additionally, to ease testing, refactor
ZipFile
factory logic out fromApkLibraryInstaller
so we can mock this scenario.Sample exception message post this change
Why it was changed
As an attempt to resolve #107.