Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include report of unscannable files in MissingLibraryException #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MrHadiSatrio
Copy link

@MrHadiSatrio MrHadiSatrio commented May 2, 2024

What has changed

To reduce ambiguity, we would want to report unscannable files whenever we're querying for getSupportedABIs(). This is done by:

  1. Employing an object which could store problematic Files information in addition to the supported ABIs.
  2. Modifying getSupportedABIs()'s catch clause to capture said information.
  3. Modifying MissingLibraryException to report it.

Additionally, to ease testing, refactor ZipFile factory logic out from ApkLibraryInstaller so we can mock this scenario.

Sample exception message post this change

Could not find 'libtest.so'. Looked for: [armeabi-v7a], but only found: []. Additionally, encountered errors while scanning: [fake.apk => java.io.IOException: Could not create zip file.].

Why it was changed

As an attempt to resolve #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear MissingLibraryException when IOException occurs during getSupportedABIs()
1 participant