Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #143

Open
naveed-ahmad opened this issue Dec 29, 2018 · 5 comments
Open

i18n support #143

naveed-ahmad opened this issue Dec 29, 2018 · 5 comments

Comments

@naveed-ahmad
Copy link

Released Android app based on this repo and got some request for adding Japanese translation. Here are the results.

screenshot_20181230_033339
screenshot_20181230_033419

English version:
screenshot_20181230_033828
screenshot_20181230_033846

I'm not sure if you would want to add i18n support or not, let me now and I can send the PR :)

@naveed-ahmad
Copy link
Author

Used google translator, and I'm not sure if translations are correct :)

Wrote some ruby script that prepare a file with object names, then used google translate for translating into Japanese. Another script then parsed the translation and filled sqlite db ( I'm using sqlite db instead of json files )

All this can be automate.

@ryanb
Copy link
Collaborator

ryanb commented Dec 31, 2018

The Android app looks pretty cool, out of curiosity, did you use just the processing script of this repo or the front-end Vue side too?

If we are just using Google Translate then I don't think it's worth adding i18n to this repo. Some browsers (such as Chrome) will automatically offer to translate a page which doesn't match their main language. Others you can get a browser extension to do translations on the fly.

If we did manual translation (perhaps in coordination with the Translation forum) it may be worth it, but that would be difficult to keep up to date as new objects are added.

@naveed-ahmad
Copy link
Author

@ryanb both, but frontend is very much customised now. Initially I had added lots of stuff in process script as well but you were too fast in releasing new stuff. Now, abandoned my fork of processing script and wrote few ruby script which will parse json files from created using onetech processing and populate sqlite db.

For frontend I have used f7 components: http://framework7.io

App is using JS based sqlite client which is very slow, next release will use native sqlite which I'm hopping will improve the speed.

@ryanb
Copy link
Collaborator

ryanb commented Dec 31, 2018

Good to know, glad you found the repo useful.

Closing this since I think most people can translate through the browser. If I receive more requests for this I will reopen.

@ryanb ryanb closed this as completed Dec 31, 2018
@ryanb
Copy link
Collaborator

ryanb commented Jan 18, 2019

Reopening this since it may be possible to get translations from the mobile devs. I think it would be more worthwhile if we have custom translations.

@ryanb ryanb reopened this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants