fix: add CORs headers to cache hit responses #53
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if CORs is enabled in the underly nginx proxy, it adds necessary CORs headers to the response.
when the proxy service finds a cache hit, it does not add any CORs related header (or any of the originally cached request's response headers). thus, on cache hits, responses that would otherwise be allowed by CORs are rejected.
as a temporary fix to this, i've added appropriate CORs headers to all responses from cache hits. long-term, some response headers should get cached with the result data.