New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new constructors for observers #41

Open

artiomn opened this issue Dec 17, 2024 · 0 comments

Assignees

Labels

bug

Contributor

artiomn commented Dec 17, 2024

UID parameter must be first in the constructors.

Now constructors look like this:

    MessageObserver(
        core::MessageEndpoint &&endpoint, MessageProcessor<Message> &&processor, core::UID uid = core::UID{true})

But there should be two constructors, with UID and without:

    MessageObserver(
        core::UID uid, core::MessageEndpoint &&endpoint, MessageProcessor<Message> &&processor);

    MessageObserver(
        core::MessageEndpoint &&endpoint, MessageProcessor<Message> &&processor)

artiomn added the bug label

artiomn assigned a-vartenkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment