Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction full text search results include reactions with no data #90

Open
jonrkarr opened this issue May 23, 2020 · 4 comments
Open

Reaction full text search results include reactions with no data #90

jonrkarr opened this issue May 23, 2020 · 4 comments
Labels
enhancement New feature or request future

Comments

@jonrkarr
Copy link
Member

Example:

  • Search for trehalose
    • HSCJRCZFDFQWRP-RDKQLNKOSA-N,NBSCHQHZLSJFNQ-GASJEMHNSA-N-->XCCTYIAWTASOJW-XVFCMESISA-N,LABSPYBHMPDTEL-LIZSDCNHSA-N
    • XLYOFNOQVPJJNP-UHFFFAOYSA-N,LABSPYBHMPDTEL-LIZSDCNHSA-N-->NBIIXXVUZAFLBC-UHFFFAOYSA-N,HDTRYLNUVZCQOY-MFAKQEFJSA-N
    • HXXFSFRBOHSIMQ-VFUOTHLCSA-N,WQZGKKKJIJFFOK-DVKNGEFBSA-N-->HDTRYLNUVZCQOY-MFAKQEFJSA-N,NBIIXXVUZAFLBC-UHFFFAOYSA-N
    • HXXFSFRBOHSIMQ-DVKNGEFBSA-N,NBSCHQHZLSJFNQ-GASJEMHNSA-N-->NBIIXXVUZAFLBC-UHFFFAOYSA-N,LABSPYBHMPDTEL-LIZSDCNHSA-N
    • HDTRYLNUVZCQOY-MFAKQEFJSA-N,GACDQMDRPRGCTN-KQYNXXCUSA-N-->WVFKPISWLUJJIJ-LIZSDCNHSA-N,WHTCPDAXWFLDIH-KQYNXXCUSA-N
    • ZKHQWZAMYRWXGA-KQYNXXCUSA-J,NBSCHQHZLSJFNQ-DVKNGEFBSA-N-->HDTRYLNUVZCQOY-MFAKQEFJSA-N,XTWYTFMLZFPYCI-KQYNXXCUSA-N
@jonrkarr jonrkarr added the bug Something isn't working label May 23, 2020
@lzy7071
Copy link
Contributor

lzy7071 commented May 23, 2020

I am not too sure what it means but here's what I did to replicate the isssue:

  • I searched for trehalose using the endpoint /ftx/text_search/num_of_index

  • I found the document with rxn_id: 1177 and kinlaw_id: [56592], that's the reaction indicated in the first bullet point.

  • There are data associated with the reaction document.

If you were referring to Km or kcat, the has_poi (meaning has parameters, or rate constants, of interest) indicates if reactions have parameter information Km or kcat`. But I think we should return all reactions in the result, regardless of if it has rate constant information or not.

@jonrkarr
Copy link
Member Author

jonrkarr commented May 24, 2020

The issue was that the search results include parameters that the frontend doesn't understand. I fixed most of the cases by extending the front end to support K_I (inhibitory constants) and parameters that use non-canonical units (by adding separate columns for units).

With my changes, the above errors are not longer relevant. Ignore the message above.

We still need to make 1 change to the reaction full text search. The full text search should only cover parameters with the following type or sbo_type:

  • 25 (k_cat)
  • 186 (V_max)
  • 27 (K_M)
  • 261 (K_I)

@jonrkarr jonrkarr added enhancement New feature or request future and removed bug Something isn't working labels May 24, 2020
@jonrkarr
Copy link
Member Author

jonrkarr commented May 24, 2020

Similar to #86 and #89, upon further reflection, I think its useful for Datanator explicitly communicate the absence of relevant data.

When we have more time, lets add an option to only return reactions that have kinetic measurements -- at least one parameter with (a) value or observed_value != null and (b) type or sbo_type is equal one of the following:

  • 25 (k_cat)
  • 186 (V_max)
  • 27 (K_M)
  • 261 (K_I)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future
Projects
None yet
Development

No branches or pull requests

2 participants