Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5 files are not properly recognized in Korean settings #3395

Open
daydreamrabbit opened this issue Nov 23, 2024 · 4 comments
Open

0.5 files are not properly recognized in Korean settings #3395

daydreamrabbit opened this issue Nov 23, 2024 · 4 comments
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@daydreamrabbit
Copy link
Contributor

What happened?

When designating a volume while creating an archive, 1.5 2.5 If you make it like this, you will have a problem of recognizing it as five volumes.

I'm not sure that's the case in other languages.

Previously, Majora inquired about the language system in Korean and left it.

Example
주술회전 1.5권
주술회전 1.5화

What did you expect?

.5 volumes should be made

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.4 - Stable

What operating system is Kavita being hosted from?

Docker (Dockerhub Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

No response

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

No response

@daydreamrabbit daydreamrabbit added the needs-triage Needs to be triaged by a developer and assigned a release label Nov 23, 2024
@daydreamrabbit daydreamrabbit changed the title If i make .5 books in Korean, i will recognize them as 5 books. 0.5 files are not properly recognized in Korean settings Nov 23, 2024
@DieselTech
Copy link
Collaborator

DieselTech commented Nov 23, 2024

Research notes:

Current Korean parsing regex: @"제?(?<Volume>\d+(\.\d)?)(권|회|화|장)

주술회전 1.5권
주술회전 1.5화

do not match against regex currently in Parser.cs


Possible enhancement: 제?(?<Volume>\d+(\.\d+)?)(권|회|화|장)

image

@daydreamrabbit
Copy link
Contributor Author

주술회전 1.5권
주술회전 1.5화

Even if i do this, the corresponding volume number will not appear in the library.

@daydreamrabbit
Copy link
Contributor Author

image

@daydreamrabbit
Copy link
Contributor Author

It goes into a 05권 library. It's the same even if i write it as 1.5권.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
Development

No branches or pull requests

2 participants