Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Non-Investigator Drowned City Cards #1452

Closed
wants to merge 5 commits into from

Conversation

Renard-Chase
Copy link
Contributor

No description provided.

@Renard-Chase Renard-Chase changed the title Added The Drowned City Cards other than George Barnaby Added Non-Investigator Drowned City Cards Dec 12, 2024
@fspoettel
Copy link
Contributor

Hello @Renard-Chase, are you aware that there is an existing PR for these cards already here #1422 ? This looks like a duplicate.

@drawntotheflame
Copy link
Contributor

yep, what @fspoettel said. @Renard-Chase you can close this. If you'd like to contribute to adding cards to ArkhamDB, please search the open PRs because we have a team already working on them. Thanks!

@fspoettel
Copy link
Contributor

@Kamalisk / @zzorba can you pin #1422 to the repository? I think that would help making it more visible and avoid duplicate effort.

@Renard-Chase
Copy link
Contributor Author

Ah, sorry about that. Didn't notice the PR from before. If it can't be pinned, maybe just a notice in the readme (or maybe a readme file in the packs folder) regarding this could be of use?

@zzorba
Copy link
Collaborator

zzorba commented Dec 12, 2024

So they don't support pinning of PRs, only issues.

I can create a milestone (TDC) and group PRs in there?

@fspoettel
Copy link
Contributor

@zzorba I created a tracking issue here: #1453 we can pin that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants