Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of Machinations? #1165

Open
NoahPeres opened this issue Aug 27, 2022 · 11 comments
Open

Status of Machinations? #1165

NoahPeres opened this issue Aug 27, 2022 · 11 comments

Comments

@NoahPeres
Copy link
Contributor

Just noticed that old mate machinations through time wasn't in here: anyone actively on this? If not I might type up some data myself in the next month or so if not too tricky!

@zzorba
Copy link
Collaborator

zzorba commented Aug 27, 2022

So far we've only typed up the cards that go in player decks. We've love to have encounter cards, it's just a lot of typing when we can't start by scraping CGDB.

If you want to take a crack at typing them up, we'd welcome the pull request!

@NoahPeres
Copy link
Contributor Author

Yeah fair fair I may take a look in the coming weeks thx for reply!

@drawntotheflame
Copy link
Contributor

@NoahPeres @zzorba is a good person to ask questions to, or you can ask me as well, as I'm usually the person to correct other people's work!

@NoahPeres
Copy link
Contributor Author

Beautiful well when I do get on this I'll make sure the online branch stays updated and try to ask questions on the way thanks for that tip! I'll try to be correct but we'll see how we go xD

@NoahPeres
Copy link
Contributor Author

https://github.com/NoahPeres/arkhamdb-json-data/tree/noahp/machinations-encounter let me know if this is wildly off track: basically just copying the format of similar cards from other sets.

Also quickly ran into a bit of a funky edge case - the Tindalos card is weird since it is a double sided location where technically each side 'belongs to a different encounter set' (one side is single group, other is epic multi) - let me know how this should be done on the data side @zzorba @Kamalisk (will prob temporarily skip and come back to it)

@zzorba
Copy link
Collaborator

zzorba commented Sep 2, 2022

Wouldn't be an arkham scenario without breaking a rule or too.

So normally when we do double sided cards, we use 'links' but we typically hide one side of it, which makes it not show up in search.

I think in this case, it probably makes the most sense to just include the card twice (as ##### and ####b) and not bother linking them at all. This way the two cards will show up when you page through by encounter-set properly (since they have their own encounter-position I assume?)

It's a bit gross, but them being two-sided actually has zero gameplay effect so I think that's probably the best course (cc: @drawntotheflame in case he feels differently)

@NoahPeres
Copy link
Contributor Author

yeah ok think I agree (was just checking out the masked hunter for a similar demo comparison of this back_link effect, that will help for old mate edwin!) that separate cards makes sense here, there is no legal situation where someone would need both at once!

@NoahPeres
Copy link
Contributor Author

How about 'position' and 'encounter_position'? I'm guessing encounter position is somewhat arbitrary but that position should correspond to the number on the card itself (in this case 5), do these need to be unique? (as each side is position 5)

@NoahPeres
Copy link
Contributor Author

another curveball I just thought of - River Docks (#87009) has 1 per investigator shroud (because why wouldn't it be needlessly compicated facepalm): would this require a modification of format.fancy_int?

@drawntotheflame
Copy link
Contributor

How about 'position' and 'encounter_position'? I'm guessing encounter position is somewhat arbitrary but that position should correspond to the number on the card itself (in this case 5), do these need to be unique? (as each side is position 5)

Position should be the same as the card number (though not card id), so a 1, 2 or 3 digit number.
Encounter position is used by the DB to determine where it shows the card. So if you have a set of 3 cards, 2 each, in an encounter set, labelling them by the 'first' card in each pair (1, 3, 5) lets the db know where to slot them. I think in this case you can put the same thing in... but we can take a look when it's live and double-check that's not caused problems.

another curveball I just thought of - River Docks (#87009) has 1 per investigator shroud (because why wouldn't it be needlessly compicated facepalm): would this require a modification of format.fancy_int?

I'd leave this just as the printed 1 shroud at the moment.

@fspoettel
Copy link
Contributor

@NoahPeres / @Kamalisk this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants