Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optimality tightening #60

Open
Kaixhin opened this issue Dec 11, 2016 · 8 comments
Open

Implement optimality tightening #60

Kaixhin opened this issue Dec 11, 2016 · 8 comments

Comments

@Kaixhin
Copy link
Owner

Kaixhin commented Dec 11, 2016

Learning to Play in a Day: Faster Deep Reinforcement Learning by Optimality Tightening potentially speeds up Q-learning by an order of magnitude! Apparently not too hard to implement either.

@petrosgk
Copy link

petrosgk commented Dec 15, 2016

I gave it a shot, however I am not sure how the discounted reward R is supposed to be used and I also need to check if future and past k-transitions are valid

https://github.com/petrosgk/Atari/tree/opt-tightening

@Kaixhin
Copy link
Owner Author

Kaixhin commented Dec 16, 2016

Awesome - I'll try and have a look soon or next week! Would you be able to test it to try and replicate one of the results from the paper?

I started on this myself as well, so will see how our implementations compare.

@Aeroone
Copy link

Aeroone commented Feb 16, 2017

Hi, have you reproduced that optimality tightening results? I have tried some games based on tensorflow and openai gym but the results seem much worse than the papers' results. I am not sure whether I misunderstand something or miss some tricks in the paper. It seems that the paper doesn't include everything about their works.

@DanielTea
Copy link

Does anyone know wether they have published the source code for optimal tightening, from the paper?

@Aeroone
Copy link

Aeroone commented Feb 16, 2017

No, they haven't published their code as far as I know. The tricks they use are not hard to implement but I can not still achieve their performance.

@petrosgk
Copy link

I have tried implementing optimality tightening (see earlier post) but the results I get are also much worse than the paper's.

@Kaixhin
Copy link
Owner Author

Kaixhin commented Feb 16, 2017

In my experience the smallest details in a paper can be key to reproducing results - and these may be missing or ambiguous. If anyone is reasonably confident in their implementation, you should try contacting one of the authors with specific questions.

@ShibiHe
Copy link

ShibiHe commented Apr 25, 2017

Hi guys,
I have released the code at https://github.com/ShibiHe/Q-Optimality-Tightening. Please have a look.

Best,
Shibi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants