fix(dist): fix diverged code paths caused by vertex-weighted graphs i…

…n combination with some empty PEs (#29)
KaHIP · Nov 13, 2024 · e5efcee · e5efcee
1 parent cf86741
commit e5efcee
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/apps/dKaMinPar.cc b/apps/dKaMinPar.cc
@@ -279,6 +279,8 @@ NodeID load_kagen_graph(const ApplicationContext &app, dKaMinPar &partitioner) {
     }
   }();
 
+  KASSERT(graph.vertex_range.second >= graph.vertex_range.first, "invalid vertex range from KaGen");
+
   auto vtxdist = BuildVertexDistribution<std::uint64_t>(graph, MPI_UINT64_T, MPI_COMM_WORLD);
 
   // If data types mismatch, we would need to allocate new memory for the graph; this is to do until

diff --git a/external/KaGen b/external/KaGen
diff --git a/kaminpar-dist/dkaminpar.cc b/kaminpar-dist/dkaminpar.cc
@@ -273,7 +273,9 @@ void dKaMinPar::import_graph(
   )});
 
   // Fill in ghost node weights
-  if (vwgt != nullptr) {
+  bool has_vwgt = vwgt != nullptr;
+  MPI_Allreduce(MPI_IN_PLACE, &has_vwgt, 1, MPI_C_BOOL, MPI_LOR, _comm);
+  if (has_vwgt) {
     graph::synchronize_ghost_node_weights(*_graph_ptr);
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }();
+      KASSERT(graph.vertex_range.second >= graph.vertex_range.first, "invalid vertex range from KaGen");
       auto vtxdist = BuildVertexDistribution<std::uint64_t>(graph, MPI_UINT64_T, MPI_COMM_WORLD);
       // If data types mismatch, we would need to allocate new memory for the graph; this is to do until
@@ Expand Down @@
+9 −1		app/KaGen.cpp
+3 −0		kagen/context.cpp
+6 −4		kagen/context.h
+0 −1		kagen/edgeweight_generators/per_edge_weight_generator.h
+1 −0		kagen/edgeweight_generators/uniform_random_generator.cpp
+222 −17		kagen/generators/generator.cpp
+2 −0		kagen/generators/generator.h
+3 −0		kagen/generators/path/path_directed.h
+12 −3		kagen/in_memory_facade.cpp
+36 −3		kagen/io.cpp
+20 −0		kagen/kagen.cpp
+12 −0		kagen/kagen.h
+14 −5		kagen/tools/utils.h
+8 −0		tests/CMakeLists.txt
+78 −0		tests/edge_weights/edge_generation_test.cpp
+184 −0		tests/permutation/permutation_test.cpp