Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logs #4

Open
Clayell opened this issue Dec 29, 2024 · 2 comments
Open

Add additional logs #4

Clayell opened this issue Dec 29, 2024 · 2 comments

Comments

@Clayell
Copy link

Clayell commented Dec 29, 2024

Hi, as a Principia player this mod seems really nice, but is lacking a lot of logs that are needed for proper Principia debugging. Namely, it is missing:

  • LocalLow/Squad/Kerbal Space Program/Player.log
  • Local/Temp/Squad/Kerbal Space Program/Crashes (I believe this one isn't present by default, but KSP will use that crash folder if it is there and I've seen posts on the forum telling people to make a crash folder there)
  • [KSP]/glog/Principia (obviously only present if using principia, only put in the 3 most recent logs as it outputs INFO, ERROR, and WARNING logs for each crash)

Could these logs be added?

@gotmachine
Copy link
Contributor

gotmachine commented Dec 29, 2024

Including player.log is useless. The only difference between player.log and KSP.log is that player.log can include crash stacktraces, which will never be present since this is an in-game tool and the previous log containing the crash info/stacktrace will have been cleared when the game is re-launched. KSP.log actually contain more information (message types, timestamps, a header with the OS version and full hardware specs), while player.log is including essentially garbage (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35) lines for every log entry.

Similarly, the Local/Temp/Squad/Kerbal Space Program/Crashes files are cleared when the game is re-launched, so those files are useless as well in the context of this tool.

I think the same fundamental limitation apply to principia crash logs as well.

I've been thinking about putting together an external, standalone bug/crash reporting tool, which would be more practical for such use cases. KSPBugReport is mainly intended as a reliable way to fully capture the state of the game in non-fatal bugs/issues situations, but it being an in-game tool inherently make it useless and unpractical in the case of a hard crash.

@Clayell
Copy link
Author

Clayell commented Dec 31, 2024

The only difference between player.log and KSP.log is that player.log can include crash stacktraces, which will never be present since this is an in-game tool and the previous log containing the crash info/stacktrace will have been cleared when the game is re-launched.

In that case, we can do the Player-prev.log, which should be exactly what we are looking for. I'll include a link in a bit that shows that Principia wants the Player.log instead of the KSP.log. I can't exactly explain it well, but you might be able to ask in #principia over in the KSP-RO discord.

Similarly, the Local/Temp/Squad/Kerbal Space Program/Crashes files are cleared when the game is re-launched, so those files are useless as well in the context of this tool.

Yep, that's absolutely true, my bad.

I think the same fundamental limitation apply to principia crash logs as well.

No, principia logs seem to be permanent (which might technically be a memory leak? strange). Principia logs are a bit strange, as sometimes there's a FATAL, INFO, WARNING, and ERROR log, but oftentimes the FATAL log is missing. Here's a relevant screenshot of some logs from glog/Principia.
image
Here are some relevant FAQs from the Principia wiki:
https://github.com/mockingbirdnest/Principia/wiki/Installing,-reporting-bugs,-and-frequently-asked-questions#windows-dialog-box-or-sigabrt
https://github.com/mockingbirdnest/Principia/wiki/Installing,-reporting-bugs,-and-frequently-asked-questions#have-a-crash-folder

I've been thinking about putting together an external, standalone bug/crash reporting tool, which would be more practical for such use cases...

I agree, that would probably be more useful, and I believe a similar tool already exists for KSP2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants