Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT vs stock comms #1992

Open
raidernick opened this issue Feb 17, 2019 · 11 comments
Open

RT vs stock comms #1992

raidernick opened this issue Feb 17, 2019 · 11 comments

Comments

@raidernick
Copy link
Contributor

I know this has been discussed once before about 2 years ago and nothing came of it but I really think we would benefit from getting rid of remote tech and moving to the stock comm system. RT is a major source of overhead for the game and I would LOVE to get rid of unnecessary required/recommended RO mods. I see no real benefit to still using RT with the amount of performance issues it causes in game. Is this something we can look into doing? This is not my area of expertise so I'd need someone willing to either do it or at least help with it.

@PhineasFreak @Theysen @pap1723

@MikeOnTea
Copy link
Contributor

MikeOnTea commented Feb 17, 2019

I'm already working on this (see #1969), though i should maybe give an update. Currently i'm trying to get mass data of early comm systems, explorer satellites/pioneer probes etc, to get a balance idea for those. Apart from that, i think concerning RO, commnet already mostly works, except vessel to vessel range which is too low.

@raidernick
Copy link
Contributor Author

the thing is I want to separate out all of the RT configs from all other configs. I don't want them mixed together any longer and they should be in a separate folder labeled for RT only. If it were only up to me I'd just totally discontinue RT support altogether and remove the configs permanently but that might upset some people.

@pap1723
Copy link
Contributor

pap1723 commented Feb 17, 2019 via email

@Bornholio
Copy link
Contributor

Bornholio commented Feb 17, 2019

I cheer for all that. #1969

@raidernick
Copy link
Contributor Author

I would like to get this fix into the RO release for ksp 1.6 if possible. I can remove all the RT references from my mods and KK mods(and put them in a separate file for now) since I maintain those but the rest someone else is going to have to do. I don't want to mess with the stock parts or other mod parts.

@PhineasFreak
Copy link
Contributor

If it were only up to me I'd just totally discontinue RT support altogether and remove the configs permanently

I think that's how it is going to be. I mean, does it make a lot of sense to keep a mod dependency that has been (almost) deprecated by a stock feature? We will lose the "antenna targeting" feature for directional antennae but i do not think that this is a major thing anyway (maybe mods like CommNet Constellation could take care of this - the developer is part of the RT group).

@kurgut
Copy link

kurgut commented Feb 18, 2019

What about the RT computer? Pretty useful and used when not connected, or is there an equivalent out there I don't know about maybe?

@PhineasFreak
Copy link
Contributor

@kurgut I think that the CommNet approach will allow the user to control the active vessel (either in full or limited mode) but you will not be able to transmit science back. We can assume that the player is the onboard computer instead of mission control and that all actions have been preloaded into the computer memory to be executed.

@Capkirk123
Copy link
Member

Real Antennas has for the most part superseded RT, and is based off the stock CommNet. Could this be considered resolved?

@DRVeyl
Copy link
Contributor

DRVeyl commented Apr 8, 2022

I'll take a minute to poke this, I guess, just from the position of doing maintenance on the GH Issues.

Nobody currently playing RP-1 [maybe for the past year+] is using RT, because RP-1 deps RealAntennas and it conflicts RT.

However, RO has not removed support for RT, there's just no patch maintenance at all being done for it at least since I've been a part of the community. Nor is there patching for stock CommNet, ie nothing is setting range values for ModuleDataTransmitters for anything except maybe the stock antenna parts.

All RT patches should currently be guarded with a :NEEDS block, same for RA.
RT saw commits through 2021, so it's not like it isn't being maintained. I'm just not sure how well its user base overlaps with RO's anymore.

The RT patches are currently still interspersed in the existing part configs. Is it worth the effort to pull them out into a separate folder? Or should this issue just be closed and the state of RT support is "whatever it was the last time we committed, there's nothing new unless some new contributor becomes heavily motivated to update missing RT patches, but currently nobody in the community fits that description." and it's not worth the effort to do the patch maintenance on what might just be NOP patches currently.

(The same is somewhat true for RA patches: they'll be in the part configs that have antennas... although while I had hoped for RO to be the repository for part configs for RA, most of the compat patches are in RA's repo. Since RA cares about the part physical size, there would not be any difference between "stock" and "RO" configs for an antenna part so it doesn't matter where the patch lives except from a maintenance perspective.)

@DRVeyl
Copy link
Contributor

DRVeyl commented Apr 9, 2022

All RT patches should currently be guarded with a :NEEDS block, same for RA.

Well, that was certainly incorrect. On anything recently maintained, it would have been added. However, as I'm going through various probably-outdated configs poking at things like reaction wheels, I'm finding several mods that blanket add the RT PMs without a NEEDS guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants