Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Unit of N0 in the "Noise" Section of Debugger? #8

Closed
Capkirk123 opened this issue May 5, 2024 · 0 comments · Fixed by #27
Closed

Wrong Unit of N0 in the "Noise" Section of Debugger? #8

Capkirk123 opened this issue May 5, 2024 · 0 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@Capkirk123
Copy link
Member

Capkirk123 commented May 5, 2024

I found that the unit of N0 in "Noise" section is dB/Hz, and I think it should be dBm/Hz, just like the N0 in the "Min Link Channel Noise Power" below.

RealAntennas/src/RealAntennasProject/Network/ConnectionDebugger.cs

Well, the "Min Link Channel Noise Power" seems also have some faults.
The two "dB" in {RATools.LogScale(data.minSymbolRate):F1} dB and {channelNoise:F1} dB" should be "dBm" I think.
The unit of "Channel Noise power" in the "Min Link Eb/N0" below is "dBm".
RealAntennas/src/RealAntennasProject/Network/ConnectionDebugger.cs
RealAntennas/src/RealAntennasProject/Network/ConnectionDebugger.cs

DRVeyl said: Appears I was a little sloppy with units in crafting the debugger. Thanks for the dimensional analysis. I'll keep this open and make a change on next release... which has no timeline currently. [Maybe if Egg's Skopos gets some progress, he has some things he wants to PR, and I might return enough for another bugfix update and merge his things.]

You're correct, N0 will be dBm/Hz. Channel noise power should be dBm. Line 129 looks correct. Line 127 I will keep minSymbolRate in dB [it's just the log scale of the bandwidth] but channelNoise at the very end is dBm.

Migrated from DRVeyl#88

@Capkirk123 Capkirk123 added the bug Something isn't working label May 5, 2024
Capkirk123 added a commit that referenced this issue Jul 13, 2024
resolves #8

Probably. The units look good to me but I'm not an expert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant