Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scale on heatshields does not increase mass (and potentially cost as well) #19

Open
Clayell opened this issue Dec 16, 2024 · 0 comments

Comments

@Clayell
Copy link

Clayell commented Dec 16, 2024

Vscale seems to increase mass and cost for all parts in ROTanks, so it seems to be an ROHeatshields-specific issue. The adjustable HS and HIAD both seem to have lines that would allow for the mass and cost to scale with the vertical scale, but as several, such as myself, have noted (such as in #17 (comment) (relevant chat)), this does not work.

// V.Scale-Mass-Cost
enableVScale = true
scaleMass = true
scaleCost = true

// V.Scale-Mass-Cost
enableVScale = true
scaleMass = true
scaleCost = true

Doing a quick search for scaleMass in the KSP-RO org shows that it seems to only be defined in ROLibrary/Source/ROLib/Modules/ModuleROTank.cs.

Even stranger, doing a search for UpdateMass in the KSP-RO org (the related function) shows that the function is not only defined in L706 of the aforementioned file, but that it is also defined in ProceduralParts/Source/ProceduralHeatshield.cs.

Perhaps something to do with the fact that its defined in Procedural Parts instead of the ROLibrary? I've reached my limit, hopefully someone can figure out this mess. 🙏

@Nazfib Nazfib mentioned this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant