diff --git a/src/app.jsx b/src/app.jsx index 271397e1..526f8c67 100644 --- a/src/app.jsx +++ b/src/app.jsx @@ -28,7 +28,7 @@ import './lib/patternfly/patternfly-4-cockpit.scss'; import { Title, Button, Alert, EmptyState, EmptyStateVariant, EmptyStateIcon, EmptyStateBody, - DataList, DataListItem, DataListItemRow, DataListItemCells, DataListCell, DataListContent, /* DataListAction, */ + DataList, DataListItem, DataListItemRow, DataListItemCells, DataListCell, DataListContent, Page, PageSection, PageSectionVariants, Select, SelectOption, Spinner, diff --git a/src/changeRemoteModal.jsx b/src/changeRemoteModal.jsx index effb65d6..246cb27e 100644 --- a/src/changeRemoteModal.jsx +++ b/src/changeRemoteModal.jsx @@ -23,11 +23,15 @@ import React, { useState } from 'react'; import PropTypes from "prop-types"; import { - Title, Button, Alert, AlertActionCloseButton, + Button, Alert, AlertActionCloseButton, Form, FormGroup, ActionGroup, TextInput, TextArea, Checkbox, - SimpleList, SimpleListItem, + DataList, + DataListCell, + DataListItem, + DataListItemRow, + DataListItemCells, Modal, } from '@patternfly/react-core'; import { PencilAltIcon, AddCircleOIcon } from '@patternfly/react-icons'; @@ -59,66 +63,60 @@ export const ChangeRemoteModal = ({ setIsModalOpen, isModalOpen, remotesList, cu ; return ( - setIsModalOpen(false)} - footer={footer}> - <> - {error && } - setSelectedRemote(currentItemProps.id)}> - {(remotesList || []).map(remote => { - return ( - (!editRepoDialogOpen || editRepoDialogOpen.name !== remote) - ? { - ev.stopPropagation(); - ev.preventDefault(); - }} - isCurrent={remote === selectedRemote}> - {remote} - - - :
- -
- ); - }).concat([ - !addNewRepoDialogOpen - ? { - ev.stopPropagation(); - ev.preventDefault(); - }} - key="add-new"> - - - :
- -
- ])} -
- -
+ <> + setIsModalOpen(false)} + footer={footer}> + <> + {error && } + + {(remotesList || []).map(remote => { + return ( + + + + {remote} + , + (!editRepoDialogOpen || editRepoDialogOpen.name !== remote) + ? + + + : + + + ]} + /> + + + ); + })} + + + + + {addNewRepoDialogOpen && } + ); }; @@ -151,46 +149,52 @@ const AddNewRepoForm = ({ setAddNewRepoDialogOpen, refreshRemotes }) => { }; return ( -
- - {_("Add New Repository")} - - {addNewRepoError && } - - setNewRepoName(name)} /> - - - setNewRepoURL(url)} /> - - - { - setNewRepoTrusted(checked); - }} /> - - - - - - + setAddNewRepoDialogOpen(false)} + footer={ + <> + + + + }> +
+ {addNewRepoError && } + + setNewRepoName(name)} /> + + + setNewRepoURL(url)} /> + + + { + setNewRepoTrusted(checked); + }} /> + + +
); }; AddNewRepoForm.propTypes = { @@ -219,13 +223,10 @@ const EditRemoteForm = ({ remoteSettings, setEditRepoDialogOpen, refreshRemotes }; return ( -
+ {error && this.setState({ error: undefined })} />} title={error} />} - - {remoteSettings.name} - .pf-c-button { - margin-left: .3em; - margin-right: .3em; -} - .pf-c-form.pf-m-horizontal { width: 100%; } @@ -108,3 +91,7 @@ .deployment-error svg { margin-right: .5rem; } + +.remote-select { + padding-bottom: var(--pf-global--spacer--md); +} diff --git a/test/check-ostree b/test/check-ostree index a1bd6303..e69c7d2a 100755 --- a/test/check-ostree +++ b/test/check-ostree @@ -446,15 +446,15 @@ class OstreeCase(MachineCase): b.click("#change-repo") b.wait_in_text(".pf-c-modal-box h1", "Change Repository") - b.wait_in_text(".pf-c-modal-box .pf-c-simple-list .pf-m-current", "local") - b.wait_in_text(".pf-c-modal-box li:last", "Add New Repository") + b.wait_in_text(".pf-c-modal-box .remote-select .pf-m-selected", "local") + b.wait_visible("#add-new-remote-btn") b.click(".pf-c-modal-box li:last button") b.click(".pf-c-modal-box #new-gpg-verify") b.set_input_text(".pf-c-modal-box #new-remote-url", "http://localhost:12344") b.set_input_text(".pf-c-modal-box #new-remote-name", "zremote test") b.click(".pf-c-modal-box #add-remote-btn") - b.wait_in_text(".pf-c-modal-box .pf-c-simple-list__item-link .pf-m-danger", "Invalid remote name") + b.wait_in_text(".pf-c-modal-box .pf-m-danger", "Invalid remote name") b.set_input_text(".pf-c-modal-box #new-remote-name", "zremote-test1") b.click(".pf-c-modal-box #add-remote-btn") @@ -462,8 +462,8 @@ class OstreeCase(MachineCase): b.wait_not_present(".pf-c-modal-box #add-remote-btn") b.wait_not_present(".pf-c-modal-box .pf-c-modal-box__footer button:disabled") b.wait_visible(".pf-c-modal-box .pf-c-modal-box__footer button.pf-m-primary") - b.wait_in_text(".pf-c-modal-box .pf-c-simple-list .pf-m-current", "local") - b.wait_in_text(".pf-c-modal-box li:last button", "Add New Repository") + b.wait_in_text(".pf-c-modal-box .remote-select .pf-m-selected", "local") + b.wait_visible("#add-new-remote-btn") b.click(".pf-c-modal-box #zremote-test1 a") b.click(".pf-c-modal-box .pf-c-modal-box__footer button.pf-m-primary") @@ -591,7 +591,7 @@ class OstreeCase(MachineCase): # Switching to branch shows pulled b.wait_text("#change-repo", "local") b.click("#change-repo") - b.wait_visible(".pf-c-modal-box .pf-c-simple-list") + b.wait_visible(".pf-c-modal-box .remote-select") b.click(".pf-c-modal-box #zremote-test1 a") b.click(".pf-c-modal-box .pf-c-modal-box__footer button.pf-m-primary") b.wait_not_present(".pf-c-modal-box") @@ -614,12 +614,12 @@ class OstreeCase(MachineCase): b.click(".pf-c-modal-box button.pf-m-danger") b.wait_not_present(".pf-c-modal-box .pf-c-form") - b.wait_not_in_text(".pf-c-modal-box .pf-c-simple-list", "zremote-test1") - b.wait_in_text(".pf-c-modal-box .pf-c-simple-list", "local") - b.wait_not_present(".pf-c-modal-box .pf-c-simple-list .pf-m-current") + b.wait_not_in_text(".pf-c-modal-box .remote-select", "zremote-test1") + b.wait_in_text(".pf-c-modal-box .remote-select", "local") + b.wait_not_present(".pf-c-modal-box .remote-select .pf-m-selected") b.wait_visible(".pf-c-modal-box .pf-c-modal-box__footer button:disabled") b.click(".pf-c-modal-box #local a") - b.wait_visible(".pf-c-modal-box .pf-c-simple-list .pf-m-current") + b.wait_visible(".pf-c-modal-box .remote-select .pf-m-selected") b.click(".pf-c-modal-box .pf-c-modal-box__footer button.pf-m-primary") b.wait_not_present(".pf-c-modal-box") b.wait_text("#change-repo", "local")