From 27dd0056767998b2cb07c5ec74952783768aec92 Mon Sep 17 00:00:00 2001 From: Nick Le Large Date: Mon, 9 Dec 2024 11:18:07 +0100 Subject: [PATCH 1/3] Add some details to the release description --- ...p-version-and-create-release-and-push-docker-images.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml index 8bb87e7..4ceb65e 100644 --- a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml +++ b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml @@ -85,7 +85,11 @@ jobs: with: artifacts: "/tmp/artifacts/release/*" tag: ${{ needs.compute-version.outputs.new_version }} - body: ${{ github.event.pull_request.body }} + body: | + ${{ github.event.pull_request.body }} + + This release is based on #${{ github.event.pull_request.number }} and has been published + by release job [${{ github.run_id }}](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). build-and-run-release-tests: needs: [compute-version, create-release] From 29652d183b7d189cf3b48aed029670e8c9128e22 Mon Sep 17 00:00:00 2001 From: Nick Le Large Date: Mon, 9 Dec 2024 11:28:52 +0100 Subject: [PATCH 2/3] Remove line break in description details. --- ...bump-version-and-create-release-and-push-docker-images.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml index 4ceb65e..c612849 100644 --- a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml +++ b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml @@ -88,8 +88,7 @@ jobs: body: | ${{ github.event.pull_request.body }} - This release is based on #${{ github.event.pull_request.number }} and has been published - by release job [${{ github.run_id }}](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). + This release is based on #${{ github.event.pull_request.number }} and has been published by release job [${{ github.run_id }}](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). build-and-run-release-tests: needs: [compute-version, create-release] From 018278256d31bd5064cc33dd7589d6267ee5e49d Mon Sep 17 00:00:00 2001 From: ll-nick <68419636+ll-nick@users.noreply.github.com> Date: Mon, 9 Dec 2024 22:58:36 +0100 Subject: [PATCH 3/3] Add suggestions from code review. Co-authored-by: Piotr Spieker --- .../bump-version-and-create-release-and-push-docker-images.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml index c612849..8a23112 100644 --- a/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml +++ b/.github/workflows/bump-version-and-create-release-and-push-docker-images.yaml @@ -88,7 +88,7 @@ jobs: body: | ${{ github.event.pull_request.body }} - This release is based on #${{ github.event.pull_request.number }} and has been published by release job [${{ github.run_id }}](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). + This release is based on pull request #${{ github.event.pull_request.number }} and has been published by release job [${{ github.run_id }}](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). build-and-run-release-tests: needs: [compute-version, create-release]