You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On our repository we've been using the format release-%major%.%minor%.%patch% for our releases. I tried to introduce your action so we could auto tag and release instead of our current manual process, but it doesn't work correctly with our format, eg always creates tag release-0.1.0 for a minor release, despite us already having many tags above that.
@matthewbpt I'm about to try a similar workflow and found your issue and was a bit worried. I read through the code and I do think it will work fine.
The problem you are having is that your tags do not meet the semver specifications. The problem is that you shouldn't have anything in front of the semver string. The function this action uses to parse the tags is documented here. You can see it can handle a "v" and extra leading "0" like 01.2.5 but not much else.
What I would recommend is for your release tag stick to just v{major}.{minor}.{patch} and for anything else v{major}.{minor}.{patch}-{EXTRA-Stuff}.
On our repository we've been using the format
release-%major%.%minor%.%patch%
for our releases. I tried to introduce your action so we could auto tag and release instead of our current manual process, but it doesn't work correctly with our format, eg always creates tagrelease-0.1.0
for a minor release, despite us already having many tags above that.I had a look at the code and it seems this logic is missing here https://github.com/K-Phoen/semver-release-action/blob/master/internal/pkg/git/git.go but I'm not so familiar with Go myself to attempt a fix and PR myself.
The text was updated successfully, but these errors were encountered: