Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific DOMExceptions should be caught #784

Open
twyatt opened this issue Nov 1, 2024 · 0 comments
Open

Specific DOMExceptions should be caught #784

twyatt opened this issue Nov 1, 2024 · 0 comments
Labels
javascript

Comments

@twyatt
Copy link
Member

twyatt commented Nov 1, 2024 •
edited
Loading

In many places, Kable is catching/handling any DOMException12, but should only be catching specific DOMException types (e.g. name == "NotFoundError", etc).

Footnotes

  1. https://github.com/JuulLabs/kable/blob/f5fd484ce1de79e9bcafd61f16d9491b965821e5/kable-core/src/jsMain/kotlin/Connection.kt#L136 ↩

  2. https://github.com/JuulLabs/kable/blob/f5fd484ce1de79e9bcafd61f16d9491b965821e5/kable-core/src/jsMain/kotlin/Connection.kt#L160 ↩
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twyatt