You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it make sense to document BluetoothDisabledException as another possible exception on Peripheral.connect? Currently only ConnectionRejectedException and CancellationException are documented.
To make my intrusion worse: I went through the code and got the following questions, which I can turn into their own issues if thats a better place for them. They both are about documentation.
It looks liks Scanner.advertisements can throw BluetoothDisabledException and ScanFailedException, which I believe would crash my app if the CoroutineContext with which I collect advertisements does not use a SupervisorJob and if I don't use Flow.catch. Would it make sense to document these exceptions on that property?
(Nearly same as my initial question) If I am not mistaken then Peripheral.connect can throw ConnectionRejectedException, BluetoothDisabledException and ConnectionLostException. Should these be documented?
I can create a PR with such documentation if desired.
Would it make sense to document
BluetoothDisabledException
as another possible exception onPeripheral.connect
? Currently onlyConnectionRejectedException
andCancellationException
are documented.To make my intrusion worse: I went through the code and got the following questions, which I can turn into their own issues if thats a better place for them. They both are about documentation.
Scanner.advertisements
can throwBluetoothDisabledException
andScanFailedException
, which I believe would crash my app if theCoroutineContext
with which I collectadvertisements
does not use aSupervisorJob
and if I don't useFlow.catch
. Would it make sense to document these exceptions on that property?Peripheral.connect
can throwConnectionRejectedException
,BluetoothDisabledException
andConnectionLostException
. Should these be documented?I can create a PR with such documentation if desired.
Originally posted by @degill in #366 (comment)
The text was updated successfully, but these errors were encountered: