Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on CentOS 7.6 #112

Open
kogdenko opened this issue Dec 23, 2019 · 9 comments
Open

Build on CentOS 7.6 #112

kogdenko opened this issue Dec 23, 2019 · 9 comments
Assignees

Comments

@kogdenko
Copy link

Hi!
Trying to build warp17 on centos7.6. Compilation failed:

tpg_rpc.c:265:5: error: implicit declaration of function ‘protobuf_c_dispatch_default’

I get protobuf-c-rpc from https://github.com/protobuf-c/protobuf-c-rpc
What I am doing wrong?

@davvore33 davvore33 self-assigned this Dec 28, 2019
@davvore33
Copy link
Collaborator

Hi @kogdenko ,

Can I ask you the results of those two commands?

$ protoc --version
$ protoc-c --version

Many Thanks

@kogdenko
Copy link
Author

$ protoc --version
libprotoc 2.5.0
$ protoc-c --version
protobuf-c 1.0.2
libprotoc 2.5.0

@davvore33
Copy link
Collaborator

Ok @kogdenko , this is what I got

$ protoc --version
libprotoc 2.6.1
$ protoc-c --version
libprotoc 2.5.0

I'm not sure how this can affect, I'll try to install it on CentOS on my own today, brb

@davvore33
Copy link
Collaborator

@kogdenko Sorry to bother you but I'm having problems compiling protoc over there, can you please provide the steps you had to do?

@kogdenko
Copy link
Author

kogdenko commented Jan 9, 2020

Hello

git clone https://github.com/protobuf-c/protobuf-c-rpc
cd protobuf-c-rpc
./autogen.sh
./configure
make

@davvore33
Copy link
Collaborator

for some reason when I try to compile and install https://github.com/protocolbuffers/protobuf/tree/2.6.1-artifacts than protobuf-c doesn't find it

@dceara
Copy link
Collaborator

dceara commented Jun 30, 2020

The installation procedure should probably be changed to install from sources from https://github.com/protobuf-c/protobuf-c-rpc instead of downloading unsigned packages. This probably requires some changes in tpg_rpc.c indeed to use the new protobuf_c_rpc_dispatch_default/protobuf_c_rpc_dispatch_add_idle/protobuf_c_rpc_dispatch_run APIs instead of the old protobuf_c_dispatch_default/protobuf_c_dispatch_add_idle/protobuf_c_dispatch_run.

@davvore33 what do you think?

@davvore33
Copy link
Collaborator

@dceara I guess we should at this point update the whole project to protobuf 3, it shouldn't be a huge amount of work anyway, I've never had the chance to look too much into it but for what i got they split the project in two parts

@dceara
Copy link
Collaborator

dceara commented Jul 16, 2020

@kogdenko, @davvore33, for CentOS 7.6 I managed to get Warp17 up and running with the following changes (still WIP):

dceara@7cfedb1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants