Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZones.build doesn't rebuild compiled files upon failure #473

Closed
omus opened this issue Sep 6, 2024 · 1 comment
Closed

TimeZones.build doesn't rebuild compiled files upon failure #473

omus opened this issue Sep 6, 2024 · 1 comment

Comments

@omus
Copy link
Member

omus commented Sep 6, 2024

While working on #471 I noticed at after I introduced the fix in #472 I couldn't use TimeZones.build("2024b") to re-build without first deleting the compiled/tzjf/v1/2024b scratch folder first:

julia> TimeZones.build("2024b")
ERROR: Cache remains empty after loading
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] reload!
   @ ~/.julia/dev/TimeZones/src/types/timezonecache.jl:40 [inlined]
 [3] _reload_tz_cache
   @ ~/.julia/dev/TimeZones/src/types/timezonecache.jl:73 [inlined]
 [4] build(version::String; force::Bool)
   @ TimeZones ~/.julia/dev/TimeZones/src/build.jl:16
 [5] build(version::String)
   @ TimeZones ~/.julia/dev/TimeZones/src/build.jl:11
 [6] top-level scope
   @ REPL[2]:1

Seems like we should check that the destination directory both exists and is not empty when skipping compilation.

@omus
Copy link
Member Author

omus commented Sep 9, 2024

Was fixed by #474

@omus omus closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant