Use backzone file as 'standard' regions #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting. Definitely warrants a test. |
omus
reviewed
Dec 13, 2022
| @@ -1,7 +1,7 @@ | |||
| # The default tz source files we care about. See "ftp://ftp.iana.org/tz/data/Makefile" | |||
| # "PRIMARY_YDATA" for listing of tz source files to include. | |||
| const STANDARD_REGIONS = [ | |||
| "africa", "antarctica", "asia", "australasia", | |||
| "africa", "antarctica", "asia", "australasia", "backzone", | |||
There was a problem hiding this comment.
More work needs to be done to determine how we should classify "backzone". From what I have read so far it seems like it should probably be treated like a LEGACY_REGION
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 95.45% 95.31% -0.15%
==========================================
Files 36 36
Lines 1760 1707 -53
==========================================
- Hits 1680 1627 -53
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pertaining to #419
Needs discussion!
I had to increase the length of the FixedTimeZone name, as there was at least one name in
backzoneof length 18 characters.