Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimensional -> dimensionless semi-major axis #15

Open
MathieuRoule opened this issue Mar 22, 2024 · 1 comment
Open

Dimensional -> dimensionless semi-major axis #15

MathieuRoule opened this issue Mar 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MathieuRoule
Copy link
Member

For now, some parameters/functions are using dimensional semi-major axis for computations.
We should get rid of the dimension by dividing by the model radial scale in most places.
@MathieuRoule MathieuRoule added the enhancement New feature or request label Mar 22, 2024
@MathieuRoule
Copy link
Member Author

In particular, bisection is sometimes called with dimensional variables -> to improve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MathieuRoule