Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share guard expressions that differ only by line number nodes. #87

Open
gafter opened this issue Jul 8, 2023 · 1 comment
Open

Share guard expressions that differ only by line number nodes. #87

gafter opened this issue Jul 8, 2023 · 1 comment
Labels
optimization

Comments

@gafter
Copy link
Member

gafter commented Jul 8, 2023

Share evaluated results for guard expressions that differ only by line number nodes.

Similarly, we should consider sharing when identical by alpha-renaming.
@gafter gafter mentioned this issue Jul 8, 2023
Closed
@mcmcgrath13
Copy link
Collaborator

Yes, I think these are both good improvements. Lets make sure the README/docs calls out that we do this sharing (cool optimization!) and that because of that when debugging only one call is expected and the variable name might not match what the user anticipated

@gafter gafter transferred this issue from JuliaServices/Rematch2.jl Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gafter @mcmcgrath13