Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume 1-based indexing. #81

Open
gafter opened this issue Apr 27, 2023 · 0 comments
Open

Don't assume 1-based indexing. #81

gafter opened this issue Apr 27, 2023 · 0 comments
Labels
enhancement

Comments

@gafter
Copy link
Member

gafter commented Apr 27, 2023

From JuliaServices/Rematch2.jl#4 (comment)

When dealing with arrays, the generated code assumes one-based indexing which is fine for most cases, but to support packages like OffsetArrays, we should switch to firstindex(a) / lastindex(a) instead of 1 and length(a) etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gafter