Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluto_export.json endpoint performance #150

Open
fonsp opened this issue Oct 25, 2024 · 1 comment
Open

pluto_export.json endpoint performance #150

fonsp opened this issue Oct 25, 2024 · 1 comment

Comments

@fonsp
Copy link
Member

fonsp commented Oct 25, 2024

Requesting the /pluto_export.json has pretty bad preformance, it currently takes about 1s for the server to respond. Let's fix it!

@fonsp
Copy link
Member Author

fonsp commented Nov 12, 2024

Might be caused by calling Pluto.frontmatter with a String here:

joinpath(start_dir, s.path)

which calls load_notebook_nobackup which will call

https://github.com/fonsp/Pluto.jl/blob/42fa2ce5fa560c676b2dd8280090dc35ad924a27/src/notebook/saving%20and%20loading.jl#L269-L281

which is a bunch of IO that we might want to avoid, which might make it related to #145

our profiling showed that a lot of time was spent in Pkg.write_env_usage


A solution would be that Pluto.load_notebook_nobackup would not store the Pkg.EnvCache, but some proxy object. And the actual Pkg.EnvCache would only get created when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant