-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large integers are truncated #61
Comments
Indeed by default all numbers are converted to Float32 for saving memory and speeding up transfer between JS and julia. I can probably skip converting Int32s into Float32 but not sure whether converting Int64 to Int32 or Float32. Any opinion on this @rossviljoen? I also wanted this to be a setting that could be controlled on a plot-by-plot basis (hence the ScopedValue for the flag) but unfortunately the processing is done during the show method which is happening outside of the ScopedValue block, so at the moment it still needs to happen globally for all plots in a notebook... |
I don't believe
If it's necessary for performance, converting (PS. thanks for the excellent package!) |
Large
Int32
s in the plot data seem to get truncated, resulting in an unwanted loss of precision when plotting withPlutoPlot(Plot(...))
, this is fixed when settingPlutoPlotly.floatval() = Val(false)
, so I think it's related to the preprocessing.The text was updated successfully, but these errors were encountered: