From 2de37966b1b02e69dd891ab58237aa13e13ea6de Mon Sep 17 00:00:00 2001 From: Anshul Singhvi Date: Sat, 25 Apr 2020 14:55:01 +0530 Subject: [PATCH 1/2] Allow llinestyle = :solid Plots also exposes this option, and it seems more intuitive than `nothing` --- src/conversions.jl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conversions.jl b/src/conversions.jl index 45b0f1d27..01e510355 100644 --- a/src/conversions.jl +++ b/src/conversions.jl @@ -617,7 +617,9 @@ convert_attribute(A::AbstractVector, ::key"linestyle") = A A `Symbol` equal to `:dash`, `:dot`, `:dashdot`, `:dashdotdot` """ function convert_attribute(ls::Symbol, ::key"linestyle") - return if ls == :dash + return if ls == :solid + nothing + elseif ls == :dash [0.0, 1.0, 2.0, 3.0, 4.0] elseif ls == :dot tick, gap = 1/2, 1/4 @@ -631,7 +633,7 @@ function convert_attribute(ls::Symbol, ::key"linestyle") ptick, pgap = 1/2, 1/4 [0.0, dtick, dtick+dgap, dtick+dgap+ptick, dtick+dgap+ptick+pgap, dtick+dgap+ptick+pgap+ptick, dtick+dgap+ptick+pgap+ptick+pgap] else - error("Unkown line style: $ls. Available: :dash, :dot, :dashdot, :dashdotdot or a sequence of numbers enumerating the next transparent/opaque region") + error("Unkown line style: $ls. Available: :solid, :dash, :dot, :dashdot, :dashdotdot, or a sequence of numbers enumerating the next transparent/opaque region.") end end From 6a45a80b6cb6c0f470165b5d4d137b7a64184913 Mon Sep 17 00:00:00 2001 From: Anshul Singhvi Date: Sat, 25 Apr 2020 15:01:23 +0530 Subject: [PATCH 2/2] Bump version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index ef0e647df..79e2f1a62 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "AbstractPlotting" uuid = "537997a7-5e4e-5d89-9595-2241ea00577e" -version = "0.10.2" +version = "0.10.3" [deps] AbstractNumbers = "85c772de-338a-5e7f-b815-41e76c26ac1f"