Use tryparse to parse platform triplet
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes parsing more robust against unknown platforms, e.g. for architectures introduced in later versions of Julia than the currently running one.
|
CI on Cirrus is broken, but all tests running on GitHub Actions are passing. I'm going to merge this PR and tag a new release to get this going, if someone comes up with a better solution which accomplish the same goal we can fix it in a followup PR. |
This was referenced Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes parsing more robust against unknown platforms, e.g. for architectures introduced in later versions of Julia than the currently running one.
This is needed to be able to publish JLL packages with RISC-V builds, also in versions of Julia older than v1.12.